rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clang/include/clang/AST/ASTContext.h:3008 +/// Insertion operator for diagnostics. +inline const DiagnosticBuilder & +operator<<(const DiagnosticBuilder &DB, ---------------- pratlucas wrote: > rnk wrote: > > It seems like there is no need for this to be defined inline, since it is > > presumably cold code. > The `inline`'s purpose here is just to allow the definition in the header > file, avoiding multiple definition errors. Yes, I am suggesting that the body be moved out of line, but this is optional. Less code in headers --> faster builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
