cryptoad added a comment. A couple of style issues to address.
================ Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:66 + +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ ---------------- s/the gcc/gcc/ ================ Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:67 +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ +#define signature_HYGON_ebx 0x6f677948 ---------------- Please use C++-style comments (https://llvm.org/docs/CodingStandards.html#comment-formatting) ================ Comment at: compiler-rt/lib/scudo/standalone/checksum.cpp:34 +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ ---------------- s/the gcc/gcc ================ Comment at: compiler-rt/lib/scudo/standalone/checksum.cpp:35 +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ +#define signature_HYGON_ebx 0x6f677948 ---------------- Please use C++-style comments (https://llvm.org/docs/CodingStandards.html#comment-formatting) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
