mibintc marked an inline comment as done.
mibintc added inline comments.
================
Comment at: clang/lib/Serialization/ASTReader.cpp:7899
+ if (FpPragmaCurrentLocation.isInvalid()) {
+ assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue &&
+ "Expected a default pragma float_control value");
----------------
yaxunl wrote:
> This changes the behavior regarding AST reader and seems to be too hash
> restriction. Essentially this requires a pch can only be used with the same
> fp options with which the pch is generated. Since there are lots of fp
> options, it is impractical to generate pch for all the combinations.
>
> We have seen regressions due to this assertion.
>
> Can this assertion be dropped or done under some options?
>
> Thanks.
>
@yaxunl Can you please send me a reproducer, I'd like to see what's going on,
not sure if just getting rid of the assertion will give the desired outcome.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72841/new/
https://reviews.llvm.org/D72841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
