arphaman marked an inline comment as done. arphaman added inline comments.
================ Comment at: clang/lib/Basic/SourceManager.cpp:397 + return false; + return FE->getUID() == SourceFile.getUID(); +} ---------------- jkorous wrote: > I don't really understand all the details here but shouldn't we use this > comparison? > ``` > bool operator==(const FileEntryRef &LHS, const FileEntryRef &RHS) > ``` The `==` comparison can return false for symlinks due to the different name, but we want to return true for symlinks to the main file as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
