jyknight added a comment.

It's worrying to me that there number of places in LLVM that at the exact 
argument value of "-fuse-ld=". E.g. in the windows and PS4 toolchains. We 
already claim to support arbitrary values and full paths, but if you specify 
"-fuse-ld=/path/to/lld-link" on Windows today, you end up with different 
behavior than "-fuse-ld=lld" (which gets translated to searching for an 
"lld-link" binary, but also triggers other conditions).

That's not a reason to not make this particular change, but if conditionals on 
the flavor of linker are going to be used, that seems like perhaps a reason why 
we should not accept arbitrary values at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80225/new/

https://reviews.llvm.org/D80225



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [P... Fangrui Song via Phabricator via cfe-commits
    • ... Fangrui Song via Phabricator via cfe-commits
    • ... Fangrui Song via Phabricator via cfe-commits
    • ... David Chisnall via Phabricator via cfe-commits
    • ... Fangrui Song via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... James Y Knight via Phabricator via cfe-commits
    • ... Keith Smiley via Phabricator via cfe-commits
    • ... Fangrui Song via Phabricator via cfe-commits

Reply via email to