owenv marked an inline comment as done. owenv added inline comments.
================ Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) + return SDError::MalformedDiagnosticRecord; ---------------- owenv wrote: > jkorous wrote: > > I am just wondering what happens with the ID. Shouldn't we pass it too? > I think the ID should be `Record[0]` in the call t > visitDocumentationURLRecord below. I based this on the handling of category > records. Sorry, I don't know how to reply without marking this as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80126/new/ https://reviews.llvm.org/D80126 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
