lebedev.ri resigned from this revision.
lebedev.ri added a comment.

In D80344#2051697 <https://reviews.llvm.org/D80344#2051697>, @tentzen wrote:

> In D80344#2051127 <https://reviews.llvm.org/D80344#2051127>, @lebedev.ri 
> wrote:
>
> > This should likely be at least 3 patches: llvm middle-end, llvm codegen, 
> > clang.
> >  Langref changes missing for new intrinsics.
> >  Please post all patches with full context (`-U99999`)
>
>
> I was thinking to update docs/ExceptionHandling.rst after this patch is 
> accepted.  Do you think this types of intrinsic should be described in 
> Langref?
>  thanks,


It may be helpful (even for the reviewers) to first specify their behavior,
instead of writing that after-the-fact "backwardly" based on the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to