hubert.reinterpretcast added subscribers: rsmith, hubert.reinterpretcast.
hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145
+  // referenced directly, without calling the thread-wrapper, so the linkage
+  // must not be changed.
+  //
----------------
rjmccall wrote:
> Is this a good idea?  It seems to be making `constinit` part of the interface 
> of a declaration, when it seems like it should strictly part of the 
> implementation.
@rsmith, fyi. My understanding is that `constinit` is as much part of the 
interface as `__thread` or `_Thread_local`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80417/new/

https://reviews.llvm.org/D80417



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to