aaron.ballman added a comment.

In D80371#2052454 <https://reviews.llvm.org/D80371#2052454>, @njames93 wrote:

> In D80371#2052069 <https://reviews.llvm.org/D80371#2052069>, @aaron.ballman 
> wrote:
>
> > LGTM, but please add a test case for the changes.
>
>
> As this fix is preventing a crash in error causing code I can't include a 
> specific test case as the clang-tidy tests will fail if there is any error 
> emitted from clang.


We support that case as well. See 
test/clang-tidy/checkers/misc-unused-using-decls-errors.cpp as an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80371/new/

https://reviews.llvm.org/D80371



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to