jfb accepted this revision. jfb added a comment. One suggestions, otherwise looks good. Thanks for doing this :)
================ Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType &M, const NodeType &N) { !(M == N); } ---------------- davidstone wrote: > Missing `return` 😱 Did this not trigger a diagnostic when building? I wonder if it's just not on? ================ Comment at: llvm/include/llvm/ADT/DirectedGraph.h:40 /// Static polymorphism: delegate implementation (via isEqualTo) to the /// derived class. + bool operator==(const DGEdge &E) const { ---------------- That comment, so informative! 😐 ================ Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:466 std::unique_ptr<int> V2 = std::make_unique<int>(0); - EXPECT_EQ(V2.get(), to_address(V2)); + EXPECT_EQ(V2.get(), (to_address)(V2)); ---------------- Can you add a comment above (with "fancy pointer") so mere mortals understand the parens? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits