nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM aside from a couple of minor nits.
================
Comment at: clang/lib/Basic/Targets/PPC.cpp:319
.Case("ppc64le", true)
+ .Case("pwr10", true)
.Case("pwr9", true)
----------------
Please remove this since HTM was removed in P10.
================
Comment at: clang/test/Preprocessor/init-ppc64.c:644
+// PPCPOWER10:#define _ARCH_PWR7 1
+// PPCPOWER10:#define _ARCH_PWR9 1
+//
----------------
I am not sure what the story is with not checking for `_ARCH_PWR8` for the P9
test, but I don't think we need to continue that precedent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80020/new/
https://reviews.llvm.org/D80020
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
