[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

[Krasimir Georgiev via Phabricator via cfe-commits]

krasimir added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2349
+// ahead in the token source.
+class AutoTokenPosition {
+  unsigned StoredPosition;
----------------
nit: I've seen similar RAII idioms in lib/Format use names like [[ 
https://github.com/llvm/llvm-project/blob/6ef45b0426a8c7b9764e102fb1a49561a3a2c118/clang/lib/Format/UnwrappedLineParser.cpp#L139
 | **Scoped**LineState ]] - just wanted to mention that naming alternative.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2372
+  }
+  // Double check  that the attribute is just something
+  // fairly simple.
----------------
nit: `check  that` has a double space


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80547/new/

https://reviews.llvm.org/D80547



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits