aaron.ballman added a comment. In D69764#2055716 <https://reviews.llvm.org/D69764#2055716>, @MyDeveloperDay wrote:
> I really do appreciate the reviews and the comments especially regarding > east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I > think most people who even considered cloning the LLVM repo know what we mean > by East/West. As such I'm going to leave the internal code that way for now. > (and the name of the TokenAnalyzer Files) I think that's totally reasonable. People working on dev tools are more likely to be aware of newer terminology anyway. > However, I have added support for Left/Right and East/West in the config, but > I'm going to refrain from adding Before/After otherwise it just gets silly > having too many options. Sounds good to me! > Whilst I've been developing this I've tried both ways, to be honest, I > instinctively know what is meant by East Const because its the style I don't > use myself (don't shoot me for that comment). But when talking in terms of > Left/Right I feel I have to think about what it means quite hard. Especially > as Right feels Wrong to me too! Would it help if we named the option `ConstPlacement` (or something along those lines) instead of `ConstStyle` as a reminder that this is about the placement of the qualifier relative to the base type? Or we could keep `ConstStyle` and go with `OnRight`|`OnLeft` (in addition to `East`|`West`) if that reads more clearly. > Let me reiterate my goal. For me the goal was to make east/west const > conversations disappear in the same way that tab and whitespace conversations > have disappeared (mostly) because I think those conversations are a waste of > good conference time. I think it's a great goal and I'm really looking forward to having this option in clang-format -- thank you for working on this feature! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
