leonardchan accepted this revision. leonardchan added a comment. In D80692#2061739 <https://reviews.llvm.org/D80692#2061739>, @aeubanks wrote:
> I foolishly submitted without running check-all, and it turns out this broke > a test under check-clang. > Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to > make sure that sancov + LTO work together, but they won't after this change > since the (Thin)LTO pipeline doesn't run things under > `registerOptimizerLastEPCallback()`. So I deleted those tests. Other > sanitizers don't work under LTO right now (at least for non-O0) because of > the same thing. Does this make sense? Makes sense. Could you also remove any CHECK lines for RUNs that were removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80692/new/ https://reviews.llvm.org/D80692 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
