sameerds added a comment.

The commit description needs fixing. These are not "llvm instructions" they are 
"AMDGCN intrinsics". They don't exist in the LangRef. Also, I would recommend 
inverting the first line of the description: "Introduce Clang builtins that are 
mapped to AMDGCN intrinsics".

EDIT: Another nitpick in the description: it's the Clang C ABI, not LLVM C ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80804/new/

https://reviews.llvm.org/D80804



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to