efriedma added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6447 + InGroup<C99>; +def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn< + "ordered comparison of complete and incomplete pointers (%0 and %1)">, ---------------- pestctrl wrote: > efriedma wrote: > > warn_typecheck_compare_complete_incomplete_pointers should be a Warning, > > not an ExtWarn. And should be DefaultIgnore. And should indicate why > > we're warning. And should be in the group C99Compat. > I'm confused by what you mean for "indicate why we're warning". Should I > change the warning text? Yes; try taking a look at the text of the other C99Compat warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
