NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Looks great, thanks! I like how it turned out, i guess let's prefer this to D79704 <https://reviews.llvm.org/D79704>. ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + ---------------- What's the point of overriding one pure virtual method with another pure virtual method? ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:977 +// implementing stack frame creations for functions without decl (functions +// passed by function pointer) methods of `ParamVarRegion` must be updated. +class ParamVarRegion : public VarRegion { ---------------- *unknown* function pointer! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
