fhahn marked an inline comment as done.
fhahn added inline comments.

================
Comment at: clang/lib/Sema/SemaExpr.cpp:4738-4739
+    bool ConversionOk = tryConvertToTy(*this, Context.getSizeType(), 
&ConvExpr);
+    assert(ConversionOk &&
+           "should be able to convert any integer type to size type");
+    return ConvExpr.get();
----------------
nickdesaulniers wrote:
> In a release build:
> ```
> llvm-project/clang/lib/Sema/SemaExpr.cpp:4737:10: warning: unused variable 
> 'ConversionOk' [-Wunused-variable]
>     bool ConversionOk = tryConvertToTy(*this, Context.getSizeType(), 
> &ConvExpr);
>          ^
> ```
Oh, of course, thanks for letting me know! Should be fixed in 
a6a42df506ca93df69725f732c396050060f026f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76791/new/

https://reviews.llvm.org/D76791



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to