LukeGeeson marked an inline comment as done. LukeGeeson added inline comments.
================ Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4 x bfloat> %a, <4 x bfloat> %b) { ---------------- miyuki wrote: > LukeGeeson wrote: > > LukeGeeson wrote: > > > miyuki wrote: > > > > Would it make sense to check the whole body of the compiled function? > > > Oops sorry, having all kinds of issues with my commit history here, give > > > me a moment to address this > > I would say it's not worth testing the whole function here, the only code > > emitted for each is the instruction mentioned in the `CHECK` and a `ret` > > surrounded by lot's of compiler labels and directives that we don't need to > > test here > I meant, just the code from the first BB label to ret (inclusive), without > directives. I suggest using `llvm/utils/update_llc_test_checks.py` to > generate the checks. Hopefully this is everything now, please let me know if there is anything else :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits