On Thu, 2020-06-04 at 13:06 +0300, Kadir Çetinkaya wrote: > Hi Mikael, > > sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know > if it helps!
Hi, Yes, now it's silent. Thank you! /Mikael > > On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator < > revi...@reviews.llvm.org> wrote: > > uabelho added inline comments. > > > > > > ================ > > Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1034 > > const PreambleData &Preamble; > > - const PreamblePatch &Patch; > > + llvm::Optional<const PreamblePatch> Patch; > > llvm::StringRef Contents; > > ---------------- > > Hi! > > > > When compiling with gcc 7.4 I see a warning that I think originates > > from this line: > > > > ``` > > [4032/4668] Building CXX object > > tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CodeC > > omplete.cpp.o > > In file included from > > /data/repo/master/llvm/include/llvm/ADT/STLExtras.h:19:0, > > from > > /data/repo/master/llvm/include/llvm/ADT/StringRef.h:12, > > from /data/repo/master/clang-tools- > > extra/clangd/URI.h:12, > > from /data/repo/master/clang-tools- > > extra/clangd/Protocol.h:26, > > from /data/repo/master/clang-tools- > > extra/clangd/Headers.h:12, > > from /data/repo/master/clang-tools- > > extra/clangd/CodeComplete.h:18, > > from /data/repo/master/clang-tools- > > extra/clangd/CodeComplete.cpp:20: > > /data/repo/master/llvm/include/llvm/ADT/Optional.h: In > > instantiation of 'void llvm::optional_detail::OptionalStorage<T, > > <anonymous> >::emplace(Args&& ...) [with Args = {const > > clang::clangd::PreamblePatch}; T = const > > clang::clangd::PreamblePatch; bool <anonymous> = false]': > > /data/repo/master/llvm/include/llvm/ADT/Optional.h:55:14: > > required from 'llvm::optional_detail::OptionalStorage<T, > > <anonymous> > > >::OptionalStorage(llvm::optional_detail::OptionalStorage<T, > > <anonymous> >&&) [with T = const clang::clangd::PreamblePatch; bool > > <anonymous> = false]' > > /data/repo/master/llvm/include/llvm/ADT/Optional.h:228:3: > > required from here > > /data/repo/master/llvm/include/llvm/ADT/Optional.h:89:12: warning: > > cast from type 'const clang::clangd::PreamblePatch*' to type > > 'void*' casts away qualifiers [-Wcast-qual] > > ::new ((void *)std::addressof(value)) > > T(std::forward<Args>(args)...); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > ``` > > > > > > > > Repository: > > rG LLVM Github Monorepo > > > > CHANGES SINCE LAST ACTION > > https://reviews.llvm.org/D77644/new/ > > > > https://reviews.llvm.org/D77644 > > > > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits