ABataev abandoned this revision. ABataev added a comment. In D81192#2074878 <https://reviews.llvm.org/D81192#2074878>, @jdoerfert wrote:
> In D81192#2074762 <https://reviews.llvm.org/D81192#2074762>, @ABataev wrote: > > > In D81192#2074732 <https://reviews.llvm.org/D81192#2074732>, @jdoerfert > > wrote: > > > > > I doubt this is the right fix. I'll take a closer look. > > > > > > I believe, the issue is caused by the new attributes for > > kmpc_critical/kmpc_end_critical functions. They are marked as > > `InaccessibleMemOrArgMemOnly` functions. Previously they did not have this > > attribute and optimizer did not move the code across these function calls. > > > I would argue it is exposed not caused by the attribute ;) > > See PR46210 Agree, the attribute exposes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
