baloghadamsoftware marked 9 inline comments as done.
================
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:117
@@ +116,3 @@
+static llvm::SmallDenseMap<int, int> createRelativeCharSizesMap() {
+ llvm::SmallDenseMap<int, int> Result(6);
+ Result[BuiltinType::UChar] = 1;
----------------
I changed to SmallDenseMap and its lookup() member function is nice. However it
unfortunately lacks an initializer_list constructor.
================
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:188
@@ -114,1 +187,3 @@
+ if (CastBuiltinType && CalcBuiltinType &&
+ !isFirstWider(CastBuiltinType->getKind(), CalcBuiltinType->getKind()))
return;
----------------
Is this an LLVM style rule? I always learned that it is the safest to use
braces even for single-line if bodies.
http://reviews.llvm.org/D17987
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
