efriedma added inline comments.

================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666
+    FirstNonOverlappingEmptyFieldHandled
+  } FirstNonOverlappingEmptyFieldStatus;
+
----------------
Instead of specifically tracking whether you've found an OverlappingEmpty 
field, could you just have something like "bool FoundNonOverlappingEmptyField = 
false;", and set it to true when you handle a field that isn't 
OverlappingEmpty?  I don't think we need to specifically track whether we've 
found an OverlappingEmpty field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79719/new/

https://reviews.llvm.org/D79719



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to