steven.zhang added a comment. It LGTM now except one comment on the test. And it seems that, we still have many other builtins implementation that didn't use the _Generic.
================ Comment at: clang/test/CodeGen/ppc-emmintrin.c:1 -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: powerpc-registered-target ---------------- So, why this line of comments is removed ? It seems that, the old test was generated by the script while the new one isn't. I expect both should generate by script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80723/new/ https://reviews.llvm.org/D80723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits