njames93 added a comment. In D79912#2083477 <https://reviews.llvm.org/D79912#2083477>, @Tridacnid wrote:
> Bug report has been closed. I'm seeing some build failures in my inbox but > eyeballing them doesn't make me think this change is related. What is the > expectation for me in this scenario? Will I get an email letting me know once > the build has been fixed? If you get those emails often it means your patch was included in a bunch of patches where one caused the failed build, usually its obvious if your changes are causing the build failure. If it is your patch you will need to push a quick fix for it, or revert if it turns out to be more complicated (As you don't have commit access you can just ask someone else to do it for you). If someone else spots that a patch is causing build failures they may leave a comment in the review to point you in the right direction. If you do decide to get commit access, its also a good idea to run `ninja check-<component>` before you push, with component being the part of the repo your patch touches, to reduce the chances of failures. In this case I ran `check-clang` and `check-clang-tools`, This isn't fool proof as some of the build slaves run of different platforms which have slight subtleties of how they handle certain things but will certainly increase your chance of success Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
