grimar added a comment.

In D78024#2087800 <https://reviews.llvm.org/D78024#2087800>, @Higuoxing wrote:

> > btw, do you know why FileCheck seems intentionally allows the case when 
> > --check-prefixes=KNOWN,UNKNOWN?
> >  I've mentioned in the description of D78110 
> > <https://reviews.llvm.org/D78110> that there are about 1000 tests that have 
> > this. but is it a feature or a something that we might want to fix?>
>
> I noticed this strange behavior of `FileCheck` as well. When I try to fix it, 
> there are lots of test failures. /subscribe


Yeah. To fix it we should prepare patches for those ~1000 tests in

> CodeGen/*
>  DebugInfo/X86/*
>  Instrumentation/*
>  Linker/*
>  MC/*
>  Other/*
>  Transforms/*

(and few other places) first. When I investigated them, I came to conclusion 
they just have unused prefixes
for no solid reason. I am not an expert in those folders/areas though. I  
thought about starting from a patch for one of those folders to see
if it will be approved without problems by people who work on the features 
there. But I had no chance to work on that yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78024/new/

https://reviews.llvm.org/D78024



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to