aaron.ballman added a comment. Generally looks good to me, but you should wait for @rsmith as he may have other ideas on the error recovery.
================ Comment at: lib/Sema/SemaDecl.cpp:6295 @@ +6294,3 @@ + Diag(NewVD->getLocation(), diag::err_concept_specialized) + << 1 << (IsPartialSpecialization ? 2 : 1); + Diag(VarTmpl->getLocation(), diag::note_previous_declaration); ---------------- Can you put comments near the magic numbers to describe what they mean? e.g., `1 /*variable*/` Same comment applies elsewhere in the patch as well. http://reviews.llvm.org/D18221 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
