NoQ added inline comments.
================ Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 + # when directory name starts with the letter `l`. + if sys.platform == 'win32': + # Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, ---------------- NoQ wrote: > Behavior of this script should not depend on the host platform. Neither > should it depend on the target platform if the graph is obtained via > cross-compilation. It should only depend on the graph itself, as it's a > simple dot file converter. The graph itself may, of course, depend on the > target platform (maybe even on the host platform). > > So it sounds like this fix should be on the C++ side. Like, i mean, i see no reason why it should be impossible to copy the original dot file from one machine to another and still be able to run the script. It's probably not a super-important use case but i don't see why would we consciously break that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82092/new/ https://reviews.llvm.org/D82092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
