sdesmalen added inline comments.
================ Comment at: clang/utils/TableGen/SveEmitter.cpp:1091 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "typedef __SVBFloat16_t svbfloat16_t;\n"; + OS << "#endif\n\n"; ---------------- Can you also add an error if `__ARM_FEATURE_SVE_BF16` is defined, but `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` isn't? something like: ```#ifndef __ARM_FEATURE_BF16_SCALAR_ARITHMETIC #error "__ARM_FEATURE_BF16_SCALAR_ARITHMETIC must be defined when __ARM_FEATURE_SVE_BF16 is defined" #endif ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
