echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land.
Couple of inline comments then looks good to go. Thank you so much for your effort here. -eric ================ Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones ---------------- MaskRay wrote: > echristo wrote: > > I'd remove the uses of blacklist and whitelist here and below. Just have > > the language and the documentation be for the new option. > `clang-tblgen -gen-opt-docs` does not seem to provide a feature to hide an > option. HelpHidden does not hide the option. Please remove blacklist and whitelist from the option description. ================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp:89 + +/// Kept for compatibility. +// RUN: %clangxx -O0 %s -S -o - -emit-llvm -fsanitize-coverage=inline-8bit-counters,indirect-calls,trace-cmp,pc-table -fsanitize-coverage-whitelist=al_bar.txt -fsanitize-coverage-blacklist=bl_bar.txt 2>&1 | not grep -f patterns.txt ---------------- Make a note that the options below ware deprecated and will be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
