dang marked 2 inline comments as done. dang added inline comments.
================ Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:468-469 + OS << "};\n"; + OS << "static const unsigned SimpleEnumValueTablesSize = " + "sizeof(SimpleEnumValueTables) / sizeof(SimpleEnumValueTable);\n"; + ---------------- dang wrote: > Bigcheese wrote: > > What happens if there are none? > There is never going to be none as there currently already is an enum-based > option that uses this setup, but it would still be nice to have a guard for > that. Getting on it... Actually this does not need any changes, it will correctly report 0 if there are no value tables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 _______________________________________________ cfe-commits mailing list firstname.lastname@example.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits