c-rhodes added inline comments.
================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_bfdot.c:3-6
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE_BF16
-D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple aarch64-none-linux-gnu
-target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
+
+// expected-error@arm_bf16.h:* {{__bf16 is not supported on this target}}
+// expected-error@arm_sve.h:* {{__bf16 is not supported on this target}}
----------------
I don't think there's any value in testing this for each ACLE test adding
bfloat support, see my comment here: https://reviews.llvm.org/D82182#2108831
There's value in checking that specific intrinsics are guarded by
`__ARM_FEATURE_SVE_BF16` (which will eventually be implied by `+bf16`), but I
suspect we could create a single test for what you've added here that just
includes `arm_sve.h`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82369/new/
https://reviews.llvm.org/D82369
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
