xazax.hun added a comment.

I only checked the test cases and the comments so far and it looks very useful 
and promising. I really hope that the performance will be ok :) I'll look at 
the actual code changes later.



================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:425
+///
+///   * "Merge (or Union) operation" merges two classes into one.  It is the
+///     main operation to produce non-trivial classes.
----------------
I found the mention of union confusing here. Especially since merging means 
intersection in terms of the ranges. I think I know what you meant but some 
additional clarification is welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82445/new/

https://reviews.llvm.org/D82445



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to