avl marked an inline comment as done. avl added inline comments.
================ Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:830 + !CI->isTailCall()) + return false; + } ---------------- laytonio wrote: > Is this correct? I think we want to check these per TRE candidate in > findTRECandidate, not just disable TRE in general if one is found. I tried to minimize changes and keep old logic here - but yes, it is better to move that check into findTRECandidate(). Will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 _______________________________________________ cfe-commits mailing list firstname.lastname@example.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits