clementval marked 3 inline comments as done.
clementval added inline comments.
================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:197
}
return DKind < OMPD_unknown ? static_cast<OpenMPDirectiveKind>(DKind)
: OMPD_unknown;
----------------
vdmitrie wrote:
> Should this be a comparison against llvm::omp::Directive_enumSize rather than
> OMPD_unknown?
>
>
> And there is an assertion in file clang/lib/Basic/OpenMPKinds.cpp
> that I guess needs to be updated the same way:
> void clang::getOpenMPCaptureRegions(
> SmallVectorImpl<OpenMPDirectiveKind> &CaptureRegions,
> OpenMPDirectiveKind DKind) {
> assert(DKind <= OMPD_unknown);
>
Good catch thx. I just created a patch to fix this D82518
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81736/new/
https://reviews.llvm.org/D81736
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
