On Thu, Jun 25, 2020 at 5:53 AM Yitzhak Mandelbaum <yitzh...@google.com> wrote:
>
> Thanks for alerting me. Why is it important to strip out this information?
> Also, might this be something we can change on the arcanist side (to not add
> to the commit message) rather than strip out on the git end?
Mostly to keep commit descriptions tidy. In a paper of git log output,
large volume of unneeded Phabricator tags dilutes useful information.
It is said that hacking on the Phabricator side can prevent pushing
some tags, but it may also lose convenience because currently one can
edit Reviewers: and Subscribers:.
> On Wed, Jun 24, 2020 at 3:28 PM Fangrui Song via Phabricator
> <revi...@reviews.llvm.org> wrote:
>>
>> MaskRay added a comment.
>>
>> Hi, your git commit contains extra Phabricator tags. You can drop
>> `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git
>> commit with the following script:
>>
>> arcfilter () {
>> arc amend
>> git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1}
>> /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/
>> {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
>> }
>>
>> `Reviewed By: ` is considered important by some people. Please keep the tag.
>> (I have updated my script to use `--date=now` (setting author date to
>> committer date))
>>
>> `https://reviews.llvm.org/D80978` contains a git pre-push hook to automate
>> this.
>>
>>
>> Repository:
>> rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D82225/new/
>>
>> https://reviews.llvm.org/D82225
>>
>>
>>
--
宋方睿
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
