john.brawn marked an inline comment as done.
john.brawn added inline comments.
================
Comment at: clang/tools/driver/driver.cpp:515
+
+ llvm::dbgs() << llvm::getBugReportMsg();
}
----------------
MaskRay wrote:
> Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is
> specified? The user requests to generate a reproduce file, but this does not
> suggest that clang has a bug. Dumping an URL is not very appropriate.
Emitting the bug report message is primarily for when
FORCE_CLANG_DIAGNOSTICS_CRASH is set (because we can get here either due to
that or -gen-reproducer). I could adjust this to only emit the message when
that is set if you'd like? Though either way we get the "PLEASE ATTACH THE
FOLLOWING FILES TO THE BUG REPORT:" message.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81672/new/
https://reviews.llvm.org/D81672
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
