c-rhodes added inline comments.
================ Comment at: clang/test/CodeGenCXX/aarch64-sve-typeinfo.cpp:4 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu %s -emit-llvm -o - \ -// RUN: -target-feature +sve | FileCheck %s +// RUN: -target-feature +sve,+bf16 | FileCheck %s ---------------- fpetrogalli wrote: > I wonder if we should keep the bf16 tests separate, as +bf16 is not needed to > generate any of the other SVE types. I don't have strong opinions here, but > it seems a better thing to do to isolate the bfloat tests in SVE in a > separate file. What do you think, @c-rhodes? > I wonder if we should keep the bf16 tests separate, as +bf16 is not needed to > generate any of the other SVE types. I don't have strong opinions here, but > it seems a better thing to do to isolate the bfloat tests in SVE in a > separate file. What do you think, @c-rhodes? I don't think either `+sve` or `+bf16` are actually required in any of these tests since they're directly using the ACLE types and not including `arm_sve.h`. Where I've added `+bf16` I've done so to be consistent, but notice there's some tests with no target feature and some that have run lines covering both. I'd prefer to keep to tests together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82668/new/ https://reviews.llvm.org/D82668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
