erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
A bunch of clang-format, plus 1 odd looking equation, otherwise this like good. ================ Comment at: llvm/lib/Support/X86TargetParser.cpp:27 +class FeatureBitset { + static constexpr unsigned NUM_FEATURE_WORDS = X86::CPU_FEATURE_MAX + 31 / 32; + ---------------- Why is this CPU_FEATURE_MAX + 0? Are you missing parens? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82731/new/ https://reviews.llvm.org/D82731 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits