kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, LGTM! ================ Comment at: clang-tools-extra/clangd/Preamble.cpp:232 class EmptyFS : public ThreadsafeFS { public: + llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> viewImpl() const override { ---------------- private ================ Comment at: clang-tools-extra/clangd/support/ThreadsafeFS.h:50 class RealThreadsafeFS : public ThreadsafeFS { public: + llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> viewImpl() const override; ---------------- make this private ? nit: also make the occurences in tests private Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82793/new/ https://reviews.llvm.org/D82793 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits