dmgreen added reviewers: dmgreen, ostannard, SjoerdMeijer. dmgreen added a comment.
Please make sure the switch in AArch64Subtarget::initializeProperties has an entry too. Do you happen to know the cpu id for host.cpp? ================ Comment at: clang/test/Driver/aarch64-cpus.c:729 +// RUN: %clang -target aarch64 -mcpu=cortex-a77 -### -c %s 2>&1 | FileCheck -check-prefix=CORTEX-A77 %s +// CORTEX-A77: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "cortex-a77" ---------------- Can you move this test up to next to the other cpus. ================ Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:128 +AARCH64_CPU_NAME("cortex-a77", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_FP16 | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | AArch64::AEK_SSBS)) AARCH64_CPU_NAME("neoverse-e1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, ---------------- Format this line - it's getting a bit long. It also would be good to make it consistent with the lines above. ================ Comment at: llvm/include/llvm/Support/ARMTargetParser.def:296 +ARM_CPU_NAME("cortex-a77", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (ARM::AEK_FP16 | ARM::AEK_DOTPROD) ) ARM_CPU_NAME("neoverse-n1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, ---------------- Little bit of extra whitespace ================ Comment at: llvm/lib/Target/AArch64/AArch64.td:954 def : ProcessorModel<"neoverse-n1", CortexA57Model, [ProcNeoverseN1]>; +def : ProcessorModel<"cortex-a77", CortexA57Model, [HasV8_2aOps, + FeatureFPARMv8, ---------------- Please add a ProcA77 and sort this next to the A76 ================ Comment at: llvm/lib/Target/ARM/ARM.td:1226 FeatureDotProd]>; +def : ProcNoItin<"cortex-a77", [ARMv82a, + FeatureHWDivThumb, ---------------- Whitespace here. And Adding a ProcA77 for consistency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82887/new/ https://reviews.llvm.org/D82887 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits