MaskRay added a comment. In D82548#2124549 <https://reviews.llvm.org/D82548#2124549>, @lh123 wrote:
> In D82548#2124546 <https://reviews.llvm.org/D82548#2124546>, @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > > commit with the following script: > > > > arcfilter () { > > arc amend > > git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} > > /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ > > {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F - > > } > > > > > > `Reviewed By: ` is considered important by some people. Please keep the > > tag. (`--date=now` is my personal preference (author dates are usually not > > useful. Using committer dates can make log almost monotonic in time)) > > > > `https://reviews.llvm.org/D80978` contains a git pre-push hook to automate > > this. > > > Thanks, should I revert it and recommit it? Please don't revert to cause unnecessary churn. Just be mindful when committing for the next time.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits