morehouse added a comment.

In D82926#2125950 <https://reviews.llvm.org/D82926#2125950>, @hctim wrote:

> So - the `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` flag is a property of the 
> build system and not that of the compiler. There are some places (android) 
> where enabling `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` globally changes 
> the behaviour of large amounts of libraries in ways that break the build 
> system.
>
> Having this flag allows us to make targeted compile-time changes to libc 
> based on sancov that don't require enabling 
> `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` across the entire build system.


Shouldn't we be fixing the fuzzing build for Android then?  
`FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` is what we use everywhere else, so I 
don't like the idea of making a new flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82926/new/

https://reviews.llvm.org/D82926



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to