lebedev.ri added a comment. New files are missing standard license header blurb. Also probably missing some tests.
================ Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires disabling integrated-cc1. ---------------- This appears unrelated to the patch. ================ Comment at: clang/tools/clang-shlib/CMakeLists.txt:40 +if (PERFETTO) +# Avoid issues with PRIVATE library +# There's probably a better fix for this ---------------- Could use more words. What issues? ================ Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x ---------------- I have concerns about this. It really should use system-provided version via `find_package()` At worst, the sources should be bundled into the tree like it's already done in some rare cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82994/new/ https://reviews.llvm.org/D82994 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
