DavidSpickett added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:296
+    return llvm::any_of(
+        Split, [](const StringRef &Extension) { return Extension == "nofp"; });
+  };
----------------
I would check what this does:
$ ./bin/clang -target arm-arm-none-eabi /tmp/test.c -c -march=armv8.1-a+nofp+fp 
-###

I'm not sure if by this point we've resolved "+nofp+fp" to simply "+fp". 
(perhaps you'd end up with a bunch of "-<feature>" followed by the same as 
"+<feature>". Either way I'd expect +fp to win.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82948/new/

https://reviews.llvm.org/D82948



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to