daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195
+ // Return if -nostdlibinc is specified as a driver option.
+ if (DriverArgs.hasArg(options::OPT_nostdlibinc))
+ return;
----------------
hubert.reinterpretcast wrote:
> stevewan wrote:
> > Can we rewrite this block of code so that it's in consistent with the
> > previous one?
> > ```
> > if (!DriverArgs.hasArg(options::OPT_nostdlibinc)) {
> > // Add <sysroot>/usr/include.
> > SmallString<128> UP(Sysroot);
> > path::append(UP, "/usr/include");
> > addSystemInclude(DriverArgs, CC1Args, UP.str());
> > }
> > ```
> I think the current expression with the early exit is friendlier for future
> expansion. @daltenty, do you have an opinion on this?
I tend to agree, everything below this point should be standard system includes
that all should get ignored with `nostdlibinc` so I think the early exit makes
sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82677/new/
https://reviews.llvm.org/D82677
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
