MaskRay added inline comments.
================ Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt<bool> EnableCallGraphProfile( + "enable-call-graph-profile", cl::init(true), cl::Hidden, ---------------- zhizhouy wrote: > MaskRay wrote: > > If there is no strong need for tuning this, please delete the option and > > PassManagerBuilder::CallGraphProfile > > > > ----- > > > > I know that `-enable-npm-call-graph-profile` exists, but it seems like a > > temporary workaround for me. @zhizhouy @void (D62627) Is the option still > > used? > Does GNU assembler recognize .cgprofile section now? > > I think we should keep this option as long as there is still usage of other > than integrated assembler. > Does GNU assembler recognize .cgprofile section now? I don't think it will ever support this section. > I think we should keep this option as long as there is still usage of other > than integrated assembler. Can you give a link about the use case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits