sammccall added a comment.

In D83178#2132034 <https://reviews.llvm.org/D83178#2132034>, @njames93 wrote:

> We should also disable any header-guard related checks. Currently with this 
> patch llvm-header-guard will fire on every header file as no macros get 
> marked as being used for header guards by the pre processor. I'm guessing 
> this is preamble related.


That's a good point, shouldn't stop us landing this fix but we should do it 
carefully.

I have a patch https://reviews.llvm.org/D78038 lying around I could clean up 
that I suspect fixes this. (I hadn't bothered so far as I hadn't seen any 
really terrible consequences, but I think this qualifies)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83178/new/

https://reviews.llvm.org/D83178



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to