aaron.ballman added a comment.

I think the change is safe to make, but I'm slightly uncomfortable with it 
because storing a `StringRef` is a somewhat questionable practice given that 
it's non-owning and it has converting constructors from dangerous types like 
`std::string`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83402/new/

https://reviews.llvm.org/D83402



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to