njames93 added a comment. I'm not a huge fan of using `error`, maybe `createError`, its used in many other parts of llvm, typically with static linkage. Its definitely out of place in Logger, but there is no where else better for it to live short of a new file which seems overkill.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83419/new/ https://reviews.llvm.org/D83419 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
